From 32af94fab8eb5ce292ed942af5f6c05d9b1f6e5b Mon Sep 17 00:00:00 2001 From: Jonny Barnes Date: Thu, 22 Sep 2016 16:00:04 +0100 Subject: [PATCH] Better error handling in case of place creation failure --- app/Http/Controllers/MicropubClientController.php | 2 +- app/Http/Controllers/MicropubController.php | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/Http/Controllers/MicropubClientController.php b/app/Http/Controllers/MicropubClientController.php index adac3d33..cbdcf1dc 100644 --- a/app/Http/Controllers/MicropubClientController.php +++ b/app/Http/Controllers/MicropubClientController.php @@ -263,7 +263,7 @@ class MicropubClientController extends Controller 'headers' => $headers, ]); } catch (ClientException $e) { - //not sure yet... + return false; } if ($response->getStatusCode() == 201) { return $response->getHeader('Location')[0]; diff --git a/app/Http/Controllers/MicropubController.php b/app/Http/Controllers/MicropubController.php index 0ff28497..c1b6dc64 100644 --- a/app/Http/Controllers/MicropubController.php +++ b/app/Http/Controllers/MicropubController.php @@ -70,7 +70,11 @@ EOD; ->header('Content-Type', 'application/json'); } if ($request->input('h') == 'card' || $request->input('type')[0] == 'h-card') { - $place = $this->placeService->createPlace($request); + try { + $place = $this->placeService->createPlace($request); + } catch (Exception $exception) { + return response()->json(['error' => true], 400); + } $content = <<