jonny/jonnybarnes.uk
Watch
1
0
Fork
You've already forked jonnybarnes.uk
 0
Code Issues 9 Pull requests Projects Releases 25 Packages Wiki Activity Actions

Fix OwnYourSwarm checkin parsing to read from properties.checkin

Browse source 
Real OwnYourSwarm requests send the checkin h-card inside
properties.checkin (as an array), not at the top level. The code
was reading from the top-level key so no Place was ever created,
leaving checkin notes blank.

Update tests to match the real request format.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Jonny Barnes 2026-03-14 19:18:00 +00:00
commit 4451fc247e
Signed by: jonny
SSH key fingerprint: SHA256:CTuSlns5U7qlD9jqHvtnVmfYV3Zwl2Z7WnJ4/dqOaL8
2 changed files with 87 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/Services/Micropub/Data/EntryData.php
View file

@ -46,7 +46,7 @@ class EntryData extends MicropubData
name: Arr::get($data, 'properties.name.0'),
description: Arr::get($data, 'properties.description.0'),
geo: Arr::get($data, 'properties.geo.0'),
checkin: Arr::get($data, 'checkin'),
checkin: Arr::get($data, 'properties.checkin.0'),
syndication: Arr::get($data, 'properties.syndication.0'),
photos: Arr::get($data, 'properties.photo'),
);

38
tests/Feature/SwarmTest.php
View file

@ -37,8 +37,7 @@ class SwarmTest extends TestCase
'value' => 'My first #checkin using Example Product',
'html' => 'My first #checkin using <a href="http://example.org">Example Product</a>',
]],
],
'checkin' => [
'checkin' => [[
'type' => ['h-card'],
'properties' => [
'name' => ['Awesome Venue'],
@ -46,6 +45,7 @@ class SwarmTest extends TestCase
'latitude' => ['1.23'],
'longitude' => ['4.56'],
],
]],
],
],
['HTTP_Authorization' => 'Bearer ' . $this->getToken()]
@ -64,7 +64,7 @@ class SwarmTest extends TestCase
}
/**
* This request would actually come from another client than OwnYourSwarm, but we’re testing
* This request would actually come from another client than OwnYourSwarm, but we're testing
* OpenStreetMap data.
*/
#[Test]
@ -83,8 +83,7 @@ class SwarmTest extends TestCase
'value' => 'My first #checkin using Example Product',
'html' => 'My first #checkin using <a href="http://example.org">Example Product</a>',
]],
],
'checkin' => [
'checkin' => [[
'type' => ['h-card'],
'properties' => [
'name' => ['Awesome Venue'],
@ -92,6 +91,7 @@ class SwarmTest extends TestCase
'latitude' => ['1.23'],
'longitude' => ['4.56'],
],
]],
],
],
['HTTP_Authorization' => 'Bearer ' . $this->getToken()]
@ -125,8 +125,7 @@ class SwarmTest extends TestCase
'value' => 'My first #checkin using Example Product',
'html' => 'My first #checkin using <a href="http://example.org">Example Product</a>',
]],
],
'checkin' => [
'checkin' => [[
'type' => ['h-card'],
'properties' => [
'name' => ['Awesome Venue'],
@ -134,6 +133,7 @@ class SwarmTest extends TestCase
'latitude' => ['1.23'],
'longitude' => ['4.56'],
],
]],
],
],
['HTTP_Authorization' => 'Bearer ' . $this->getToken()]
@ -159,8 +159,7 @@ class SwarmTest extends TestCase
'properties' => [
'published' => [Carbon::now()->toDateTimeString()],
'syndication' => ['https://www.swarmapp.com/checkin/def'],
],
'checkin' => [
'checkin' => [[
'type' => ['h-card'],
'properties' => [
'name' => ['Awesomer Venue'],
@ -168,6 +167,7 @@ class SwarmTest extends TestCase
'latitude' => ['3.21'],
'longitude' => ['6.54'],
],
]],
],
],
['HTTP_Authorization' => 'Bearer ' . $this->getToken()]
@ -202,13 +202,13 @@ class SwarmTest extends TestCase
'value' => 'My first #checkin using Example Product',
'html' => 'My first #checkin using <a href="http://example.org">Example Product</a>',
]],
],
'checkin' => [
'checkin' => [[
'type' => ['h-card'],
'properties' => [
'name' => ['Awesome Venue'],
'url' => ['https://foursquare.com/v/123456'],
],
]],
],
],
['HTTP_Authorization' => 'Bearer ' . $this->getToken()]
@ -240,21 +240,21 @@ class SwarmTest extends TestCase
'value' => 'My first #checkin using Example Product',
'html' => 'My first #checkin using <a href="http://example.org">Example Product</a>',
]],
],
'location' => [
'location' => [[
'type' => ['h-adr'],
'properties' => [
'latitude' => ['1.23'],
'longitude' => ['4.56'],
'street-address' => ['Awesome Street'],
],
],
'checkin' => [
]],
'checkin' => [[
'type' => ['h-card'],
'properties' => [
'name' => ['Awesome Venue'],
'url' => ['https://foursquare.com/v/123456'],
],
]],
],
],
['HTTP_Authorization' => 'Bearer ' . $this->getToken()]
@ -279,11 +279,10 @@ class SwarmTest extends TestCase
'type' => ['h-entry'],
'properties' => [
'published' => [Carbon::now()->toDateTimeString()],
],
'syndication' => [
'https://www.swarmapp.com/user/199841/checkin/5c4b1ac56dcf04002c0a4f58',
],
'checkin' => [
'checkin' => [[
'type' => ['h-card'],
'properties' => [
'name' => ['Forbidden Planet'],
@ -296,8 +295,8 @@ class SwarmTest extends TestCase
'postal-code' => ['M1 1JR'],
],
'value' => 'https://foursquare.com/v/4ade0e46f964a520bf6f21e3',
],
'location' => [
]],
'location' => [[
'type' => ['h-adr'],
'properties' => [
'latitude' => [53.483153021713],
@ -307,6 +306,7 @@ class SwarmTest extends TestCase
'country-name' => ['United Kingdom'],
'postal-code' => ['M1 1JR'],
],
]],
],
],
['HTTP_Authorization' => 'Bearer ' . $this->getToken()]