From 903ebf56eb0565b080a920a9449a7b0f03df4e64 Mon Sep 17 00:00:00 2001 From: Jonny Barnes Date: Tue, 23 Aug 2022 20:50:19 +0100 Subject: [PATCH] Update code to work with stricter JWT library checks --- app/Providers/AppServiceProvider.php | 2 +- tests/Feature/TokenServiceTest.php | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/app/Providers/AppServiceProvider.php b/app/Providers/AppServiceProvider.php index 79eda263..9a14487b 100644 --- a/app/Providers/AppServiceProvider.php +++ b/app/Providers/AppServiceProvider.php @@ -85,7 +85,7 @@ class AppServiceProvider extends ServiceProvider // Configure JWT builder $this->app->bind('Lcobucci\JWT\Configuration', function () { - $key = InMemory::plainText('testing'); + $key = InMemory::plainText(config('app.key')); $config = Configuration::forSymmetricSigner(new Sha256(), $key); diff --git a/tests/Feature/TokenServiceTest.php b/tests/Feature/TokenServiceTest.php index 9935c4fe..97e2328a 100644 --- a/tests/Feature/TokenServiceTest.php +++ b/tests/Feature/TokenServiceTest.php @@ -37,7 +37,10 @@ class TokenServiceTest extends TestCase $this->assertSame($data, $validData); } - /** @test */ + /** + * @test + * @throws \Exception + */ public function tokensWithDifferentSigningKeyThrowsException(): void { $this->expectException(RequiredConstraintsViolated::class); @@ -56,7 +59,7 @@ class TokenServiceTest extends TestCase ->withClaim('me', $data['me']) ->withClaim('scope', $data['scope']) ->withClaim('nonce', bin2hex(random_bytes(8))) - ->getToken($config->signer(), InMemory::plainText('r4andomk3y')) + ->getToken($config->signer(), InMemory::plainText(random_bytes(32))) ->toString(); $service = new TokenService();