jonny/jonnybarnes.uk
1
0
Fork 0
Code Issues 8 Pull requests Projects Releases 5 Packages Wiki Activity Actions

Make sure when a note has no content, null is saved to the db, not ''

Browse source
This commit is contained in:
Jonny Barnes 2018-01-06 23:12:03 +00:00
parent 56d180729e
commit ae2dc99069
3 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/Models/Note.php
View file

@ -132,7 +132,11 @@ class Note extends Model
*/ */
public function setNoteAttribute($value) public function setNoteAttribute($value)
{ {
$this->attributes['note'] = normalizer_normalize($value, Normalizer::FORM_C); $normalized = normalizer_normalize($value, Normalizer::FORM_C);
if ($normalized === '') { //we don’t want to save empty strings to the db
$normalized = null;
}
$this->attributes['note'] = $normalized;
} }
/** /**

1
changelog.md
View file

@ -3,6 +3,7 @@
## Version {next} ## Version {next}
- Update dependencies and recompile frontend assets, fix tests - Update dependencies and recompile frontend assets, fix tests
- Only normalise tags in the URL, not in the actual link text - Only normalise tags in the URL, not in the actual link text
- Make sure when a note has no content, null is saved to the db, not `''`
## Version 0.15 (2017-12-24) ## Version 0.15 (2017-12-24)
- Add simple checkins, i.e. checkins with no note content, for now add a default note for these - Add simple checkins, i.e. checkins with no note content, for now add a default note for these

2
tests/Feature/SwarmTest.php
View file

@ -146,12 +146,14 @@ class SwarmTest extends TestCase
$response $response
->assertStatus(201) ->assertStatus(201)
->assertJson(['response' => 'created']); ->assertJson(['response' => 'created']);
//dump($response->__get('headers')->get('location'));
$this->assertDatabaseHas('places', [ $this->assertDatabaseHas('places', [
'external_urls' => '{"foursquare": "https://foursquare.com/v/654321"}' 'external_urls' => '{"foursquare": "https://foursquare.com/v/654321"}'
]); ]);
$this->assertDatabaseHas('notes', [ $this->assertDatabaseHas('notes', [
'swarm_url' => 'https://www.swarmapp.com/checkin/def' 'swarm_url' => 'https://www.swarmapp.com/checkin/def'
]); ]);
$this->get($response->__get('headers')->get('location'))->assertSee('round pushpin');
} }
public function test_faked_ownyourswarm_request_saves_just_post_when_error_in_checkin_data() public function test_faked_ownyourswarm_request_saves_just_post_when_error_in_checkin_data()