Struct Types

Squashed commit of the following:

commit 74ed84617fcbecf661695763323e50d049a88db7
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date:   Mon Jan 15 12:46:29 2018 +0000

    Test passes so remove the dump statement

commit a7d3323be02da64f76e8ec88713e3de84a13ded7
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date:   Mon Jan 15 12:40:35 2018 +0000

    Values with spaces need to be quoted

commit 58a120bb238f14346793c388b948b7351d3b51fd
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date:   Mon Jan 15 12:37:23 2018 +0000

    We need a diplay name for the tests to work now we are using strict type checking

commit b46f177053bd697db9a4835d073f2f37e088b26f
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date:   Mon Jan 15 12:31:29 2018 +0000

    Get travis to show more info about failing test

commit 60323f3ce5a0561329a1721ee94821571cdcc86a
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date:   Mon Jan 15 12:23:27 2018 +0000

    Remove un-used namnepsace imports

commit 096d3505920bc94ff8677c77430eca0aae0be58a
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date:   Mon Jan 15 12:21:55 2018 +0000

    we need php7.2 for object type-hint

commit bb818bc19c73d02d510af9f002199f5718a54608
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date:   Mon Jan 15 12:15:48 2018 +0000

    Added lots of strict_types

app/Http/Controllers/Admin/ArticlesController.php

@@ -1,19 +1,23 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Http\Controllers\Admin;
 
 use App\Models\Article;
+use Illuminate\View\View;
 use Illuminate\Http\Request;
 use App\Http\Controllers\Controller;
+use Illuminate\Http\RedirectResponse;
 
 class ArticlesController extends Controller
 {
     /**
      * List the articles that can be edited.
      *
-     * @return \Illuminate\View\Factory view
+     * @return \Illuminate\View\View
      */
-    public function index()
+    public function index(): View
     {
         $posts = Article::select('id', 'title', 'published')->orderBy('id', 'desc')->get();
 
@@ -23,9 +27,9 @@ class ArticlesController extends Controller
     /**
      * Show the new article form.
      *
-     * @return \Illuminate\View\Factory view
+     * @return \Illuminate\View\View
      */
-    public function create()
+    public function create(): View
     {
         $message = session('message');
 
@@ -35,23 +39,22 @@ class ArticlesController extends Controller
     /**
      * Process an incoming request for a new article and save it.
      *
-     * @param  \Illuminate\Http\Request $request
-     * @return \Illuminate\View\Factory view
+     * @return \Illuminate\Http\RedirectResponse
      */
-    public function store(Request $request)
+    public function store(): RedirectResponse
     {
         //if a `.md` is attached use that for the main content.
-        if ($request->hasFile('article')) {
-            $file = $request->file('article')->openFile();
+        if (request()->hasFile('article')) {
+            $file = request()->file('article')->openFile();
             $content = $file->fread($file->getSize());
         }
-        $main = $content ?? $request->input('main');
+        $main = $content ?? request()->input('main');
         $article = Article::create(
             [
-                'url' => $request->input('url'),
-                'title' => $request->input('title'),
+                'url' => request()->input('url'),
+                'title' => request()->input('title'),
                 'main' => $main,
-                'published' => $request->input('published') ?? 0,
+                'published' => request()->input('published') ?? 0,
             ]
         );
 
@@ -61,10 +64,10 @@ class ArticlesController extends Controller
     /**
      * Show the edit form for an existing article.
      *
-     * @param  string  The article id
-     * @return \Illuminate\View\Factory view
+     * @param  int  $articleId
+     * @return \Illuminate\View\View
      */
-    public function edit($articleId)
+    public function edit(int $articleId): View
     {
         $post = Article::select(
             'title',
@@ -79,17 +82,16 @@ class ArticlesController extends Controller
     /**
      * Process an incoming request to edit an article.
      *
-     * @param  \Illuminate\Http\Request $request
-     * @param  string
-     * @return \Illuminate|View\Factory view
+     * @param  int  $articleId
+     * @return \Illuminate\Http\RedirectResponse
      */
-    public function update(Request $request, $articleId)
+    public function update(int $articleId): RedirectResponse
     {
         $article = Article::find($articleId);
-        $article->title = $request->input('title');
-        $article->url = $request->input('url');
-        $article->main = $request->input('main');
-        $article->published = $request->input('published') ?? 0;
+        $article->title = request()->input('title');
+        $article->url = request()->input('url');
+        $article->main = request()->input('main');
+        $article->published = request()->input('published') ?? 0;
         $article->save();
 
         return redirect('/admin/blog');
@@ -98,10 +100,10 @@ class ArticlesController extends Controller
     /**
      * Process a request to delete an aricle.
      *
-     * @param  string The article id
-     * @return \Illuminate\View\Factory view
+     * @param  int  $articleId
+     * @return \Illuminate\Http\RedirectResponse
      */
-    public function destroy($articleId)
+    public function destroy(int $articleId): RedirectResponse
     {
         Article::where('id', $articleId)->delete();