Struct Types

Squashed commit of the following:

commit 74ed84617fcbecf661695763323e50d049a88db7
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date:   Mon Jan 15 12:46:29 2018 +0000

    Test passes so remove the dump statement

commit a7d3323be02da64f76e8ec88713e3de84a13ded7
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date:   Mon Jan 15 12:40:35 2018 +0000

    Values with spaces need to be quoted

commit 58a120bb238f14346793c388b948b7351d3b51fd
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date:   Mon Jan 15 12:37:23 2018 +0000

    We need a diplay name for the tests to work now we are using strict type checking

commit b46f177053bd697db9a4835d073f2f37e088b26f
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date:   Mon Jan 15 12:31:29 2018 +0000

    Get travis to show more info about failing test

commit 60323f3ce5a0561329a1721ee94821571cdcc86a
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date:   Mon Jan 15 12:23:27 2018 +0000

    Remove un-used namnepsace imports

commit 096d3505920bc94ff8677c77430eca0aae0be58a
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date:   Mon Jan 15 12:21:55 2018 +0000

    we need php7.2 for object type-hint

commit bb818bc19c73d02d510af9f002199f5718a54608
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date:   Mon Jan 15 12:15:48 2018 +0000

    Added lots of strict_types

app/Http/Controllers/Admin/NotesController.php

@@ -1,20 +1,24 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Http\Controllers\Admin;
 
 use App\Models\Note;
+use Illuminate\View\View;
 use Illuminate\Http\Request;
 use App\Jobs\SendWebMentions;
 use App\Http\Controllers\Controller;
+use Illuminate\Http\RedirectResponse;
 
 class NotesController extends Controller
 {
     /**
      * List the notes that can be edited.
      *
-     * @return \Illuminate\View\Factory view
+     * @return \Illuminate\View\View
      */
-    public function index()
+    public function index(): View
     {
         $notes = Note::select('id', 'note')->orderBy('id', 'desc')->get();
         foreach ($notes as $note) {
@@ -27,9 +31,9 @@ class NotesController extends Controller
     /**
      * Show the form to make a new note.
      *
-     * @return \Illuminate\View\Factory view
+     * @return \Illuminate\View\View
      */
-    public function create()
+    public function create(): View
     {
         return view('admin.notes.create');
     }
@@ -37,14 +41,13 @@ class NotesController extends Controller
     /**
      * Process a request to make a new note.
      *
-     * @param Illuminate\Http\Request $request
-     * @todo  Sort this mess out
+     * @return \Illuminate\Http\RedirectResponse
      */
-    public function store(Request $request)
+    public function store(): RedirectResponse
     {
         Note::create([
-            'in-reply-to' => $request->input('in-reply-to'),
-            'note' => $request->input('content'),
+            'in-reply-to' => request()->input('in-reply-to'),
+            'note' => request()->input('content'),
         ]);
 
         return redirect('/admin/notes');
@@ -53,10 +56,10 @@ class NotesController extends Controller
     /**
      * Display the form to edit a specific note.
      *
-     * @param  string The note id
-     * @return \Illuminate\View\Factory view
+     * @param  int  $noteId
+     * @return \Illuminate\View\View
      */
-    public function edit($noteId)
+    public function edit(int $noteId): View
     {
         $note = Note::find($noteId);
         $note->originalNote = $note->getOriginal('note');
@@ -68,18 +71,18 @@ class NotesController extends Controller
      * Process a request to edit a note. Easy since this can only be done
      * from the admin CP.
      *
-     * @param  \Illuminate\Http\Request $request
-     * @return \Illuminate\View\Factory view
+     * @param  int  $noteId
+     * @return \Illuminate\Http\RedirectResponse
      */
-    public function update($noteId, Request $request)
+    public function update(int $noteId): RedirectResponse
     {
         //update note data
         $note = Note::findOrFail($noteId);
-        $note->note = $request->input('content');
-        $note->in_reply_to = $request->input('in-reply-to');
+        $note->note = request()->input('content');
+        $note->in_reply_to = request()->input('in-reply-to');
         $note->save();
 
-        if ($request->input('webmentions')) {
+        if (request()->input('webmentions')) {
             dispatch(new SendWebMentions($note));
         }
 
@@ -89,12 +92,12 @@ class NotesController extends Controller
     /**
      * Delete the note.
      *
-     * @param  int id
-     * @return view
+     * @param  int  $noteId
+     * @return \Illuminate\Http\RedirectResponse
      */
-    public function destroy($id)
+    public function destroy(int $noteId): RedirectResponse
     {
-        $note = Note::findOrFail($id);
+        $note = Note::findOrFail($noteId);
         $note->delete();
 
         return redirect('/admin/notes');