Fix CSRF exemption and array-input crash on revocation/introspection
An Opus code review of the branch caught two real bugs the test suite
structurally couldn't see:
- /revocation and /introspect were never added to bootstrap/app.php's
CSRF except list, so both were fully broken (403) for any real
external client, despite every feature test passing — CSRF
verification is short-circuited entirely while running tests.
Verified live against the running app before and after the fix, and
added a regression test that asserts against the actual configured
exemptions rather than relying on request-time behavior that tests
can't exercise.
- An array-shaped `token` param (e.g. token[]=a&token[]=b) crashed
both endpoints with a 500, since this app promotes PHP warnings
("Array to string conversion") to exceptions. Fixed at the shared
root, MicropubToken::findActive(), which also closes the same latent
hole in VerifyMicropubToken's access_token param that predates this
branch. Verified live and covered with regression tests.
Also applied the review's lower-severity findings: added the missing
introspection_endpoint Link header and metadata test assertions,
removed the now-dead is_string($scopes) array branch in the Micropub
handlers and media controller (scope is unconditionally a string from
the DB now, this guarded against a JWT-array-claim shape that can no
longer occur), dropped a redundant #[Table] model attribute, sized
token_hash to its actual 64-char length, and removed a one-off inline
style in the admin view.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014625MfkGZ7GVdbqKme4a8L
This commit is contained in:
parent
24da24a677
commit
faf8e5c1ec
14 changed files with 98 additions and 31 deletions
|
|
@ -29,9 +29,10 @@ class IndieAuthTest extends TestCase
|
|||
'issuer' => config('app.url'),
|
||||
'authorization_endpoint' => route('indieauth.start'),
|
||||
'token_endpoint' => route('indieauth.token'),
|
||||
'revocation_endpoint' => route('indieauth.revocation'),
|
||||
'introspection_endpoint' => route('indieauth.introspection'),
|
||||
'introspection_endpoint_auth_methods_supported' => ['Bearer'],
|
||||
'code_challenge_methods_supported' => ['S256'],
|
||||
// 'introspection_endpoint' => 'introspection_endpoint',
|
||||
// 'introspection_endpoint_auth_methods_supported' => ['none'],
|
||||
]);
|
||||
}
|
||||
|
||||
|
|
@ -795,4 +796,31 @@ class IndieAuthTest extends TestCase
|
|||
$response->assertStatus(200);
|
||||
$response->assertExactJson(['active' => false]);
|
||||
}
|
||||
|
||||
#[Test]
|
||||
public function revocation_does_not_error_on_an_array_shaped_token_param(): void
|
||||
{
|
||||
$response = $this->post('/revocation', ['token' => ['a', 'b']]);
|
||||
|
||||
$response->assertStatus(200);
|
||||
}
|
||||
|
||||
#[Test]
|
||||
public function introspection_does_not_error_on_an_array_shaped_token_param(): void
|
||||
{
|
||||
$callerToken = resolve(TokenService::class)->getNewToken([
|
||||
'me' => config('app.url'),
|
||||
'client_id' => 'https://app.example.com',
|
||||
'scope' => 'create',
|
||||
]);
|
||||
|
||||
$response = $this->post(
|
||||
'/introspect',
|
||||
['token' => ['a', 'b']],
|
||||
['HTTP_Authorization' => 'Bearer '.$callerToken]
|
||||
);
|
||||
|
||||
$response->assertStatus(200);
|
||||
$response->assertExactJson(['active' => false]);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue