Improve tests feature
Squashed commit of the following:
commit 13ac266b79b496d62291a07f4f5f81940d217ccb
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Sun Jan 20 17:17:25 2019 +0000
test on 7.2 and 7.3, download phpcs directly from github
commit 692cc7dfe165a7ecaf9dba9498c868193b749aee
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Sun Jan 20 17:10:16 2019 +0000
Drop code-coverage for now, PHP7.3 and Xdebug aren’t playing ball at the moment
commit 03d262c47af79cfa0ce4937cc8e196e3b6f5877a
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Sun Jan 20 17:09:48 2019 +0000
Use an excewption when generating twitter content of a note
commit e2df1e5cebebd30473787c924f495a5687145fb8
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Sun Jan 20 17:08:48 2019 +0000
Updating dependencies
commit 8008eb53854eddefaa4e302f95353c626b3062ef
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Sun Nov 25 16:09:32 2018 +0000
Fix S3 URLs to use config settings
commit 941864b9d6c6cb9d87b4b95385ada67f55de837c
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Sat Nov 24 21:28:19 2018 +0000
Increase code-coverage in the notes unit tests
commit 4a253d3c5c1854dd8ea01d975bb8e709ae697393
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Tue Nov 20 18:26:59 2018 +0000
Don’t create new notes in null note test
commit 9616cd2b66bc6f26b2d3266f95cf1be894aaed99
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Tue Nov 20 18:23:05 2018 +0000
Use Laravel’s FileSystem class to better deal with files/folders in the tearDown methods
commit 294f7961ec03d26cc45845632a97b2521a58f403
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Tue Nov 20 18:22:28 2018 +0000
Add more unit tests for the geocoding method
commit 43328e3ce249fe8df95770f1275cab97f4ca88bc
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Tue Nov 20 18:18:36 2018 +0000
Improve the revereseGeoCode method
commit 84424e1d8274bfe62bc5f0a7556e5732bf094178
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Tue Nov 20 15:03:14 2018 +0000
Test that empty notes are saved to the DB as null
commit 77fd87b81323457ce6f578ed7f359ceb6b3ce6b6
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Sat Oct 13 20:20:03 2018 +0100
Increase test coverage to 100% for the WebMention model
commit 4b6da595dc1efc025470279e9012c2a2a90ec3ef
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Sat Oct 13 18:49:33 2018 +0100
Improving test coverage
commit 895061b8dd0ddf4fbc321e4f371ea148d9b3007f
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Sat Oct 13 17:19:35 2018 +0100
Improvements in Like tests and code, and WebMentions processing tests and code
commit f9a8b96f2c8b1ef22e97d3dc634ee76d97c25cb5
Author: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Fri Oct 12 22:43:49 2018 +0100
Don’t track the coverage files in git
This commit is contained in:
parent
d43386b3b9
commit
ffa9756cb7
17 changed files with 1322 additions and 440 deletions
|
|
@ -3,11 +3,18 @@
|
|||
namespace Tests\Unit;
|
||||
|
||||
use Tests\TestCase;
|
||||
use App\Models\{Note, Tag};
|
||||
use GuzzleHttp\Client;
|
||||
use GuzzleHttp\HandlerStack;
|
||||
use GuzzleHttp\Psr7\Response;
|
||||
use App\Models\{Media, Note, Tag};
|
||||
use GuzzleHttp\Handler\MockHandler;
|
||||
use Thujohn\Twitter\Facades\Twitter;
|
||||
use Illuminate\Foundation\Testing\DatabaseTransactions;
|
||||
|
||||
class NotesTest extends TestCase
|
||||
{
|
||||
use DatabaseTransactions;
|
||||
|
||||
/**
|
||||
* Test the getNoteAttribute method. This will then also call the
|
||||
* relevant sub-methods.
|
||||
|
|
@ -96,4 +103,190 @@ class NotesTest extends TestCase
|
|||
'tag_id' => $tag->id,
|
||||
]);
|
||||
}
|
||||
|
||||
/** @test */
|
||||
public function blank_note_should_be_saved_as_null()
|
||||
{
|
||||
$note = new Note(['note' => '']);
|
||||
|
||||
$this->assertNull($note->note);
|
||||
}
|
||||
|
||||
/** @test */
|
||||
public function reverse_geocode_an_attraction()
|
||||
{
|
||||
$json = <<<JSON
|
||||
{"place_id":"198791063","licence":"Data © OpenStreetMap contributors, ODbL 1.0. https:\/\/osm.org\/copyright","osm_type":"relation","osm_id":"5208404","lat":"51.50084125","lon":"-0.142990166340849","display_name":"Buckingham Palace, Ambassador's Court, St. James's, Victoria, Westminster, London, Greater London, England, SW1E 6LA, United Kingdom","address":{"attraction":"Buckingham Palace","road":"Ambassador's Court","neighbourhood":"St. James's","suburb":"Victoria","city":"London","state_district":"Greater London","state":"England","postcode":"SW1E 6LA","country":"UK","country_code":"gb"},"boundingbox":["51.4997342","51.5019473","-0.143984","-0.1413002"]}
|
||||
JSON;
|
||||
$mock = new MockHandler([
|
||||
new Response(200, ['Content-Type' => 'application/json'], $json),
|
||||
]);
|
||||
$handler = HandlerStack::create($mock);
|
||||
$client = new Client(['handler' => $handler]);
|
||||
|
||||
$this->app->instance(Client::class, $client);
|
||||
|
||||
$note = new Note();
|
||||
$address = $note->reverseGeoCode(51.50084, -0.14264);
|
||||
|
||||
$this->assertEquals('<span class="p-locality">Victoria, London</span>, <span class="p-country-name">UK</span>', $address);
|
||||
}
|
||||
|
||||
/** @test */
|
||||
public function reverse_geocode_a_suburb()
|
||||
{
|
||||
$json = <<<JSON
|
||||
{"place_id":"96518506","licence":"Data © OpenStreetMap contributors, ODbL 1.0. https:\/\/osm.org\/copyright","osm_type":"way","osm_id":"94107885","lat":"51.0225764535969","lon":"0.906664040464189","display_name":"Melon Lane, Newchurch, Shepway, Kent, South East, England, TN29 0AS, United Kingdom","address":{"road":"Melon Lane","suburb":"Newchurch","city":"Shepway","county":"Kent","state_district":"South East","state":"England","postcode":"TN29 0AS","country":"UK","country_code":"gb"},"boundingbox":["51.0140377","51.0371494","0.8873312","0.9109506"]}
|
||||
JSON;
|
||||
$mock = new MockHandler([
|
||||
new Response(200, ['Content-Type' => 'application/json'], $json),
|
||||
]);
|
||||
$handler = HandlerStack::create($mock);
|
||||
$client = new Client(['handler' => $handler]);
|
||||
|
||||
$this->app->instance(Client::class, $client);
|
||||
|
||||
$note = new Note();
|
||||
$address = $note->reverseGeoCode(51.02, 0.91);
|
||||
|
||||
$this->assertEquals('<span class="p-locality">Newchurch, Shepway</span>, <span class="p-country-name">UK</span>', $address);
|
||||
}
|
||||
|
||||
/** @test */
|
||||
public function reverse_geocode_a_city()
|
||||
{
|
||||
// Note I’ve modified this JSON response so it only contains the
|
||||
// city the Uni is in
|
||||
$json = <<<JSON
|
||||
{"place_id":"198561071","licence":"Data © OpenStreetMap contributors, ODbL 1.0. https:\/\/osm.org\/copyright","osm_type":"relation","osm_id":"1839026","lat":"53.46600455","lon":"-2.23300880782987","display_name":"University of Manchester - Main Campus, Brunswick Street, Curry Mile, Ardwick, Manchester, Greater Manchester, North West England, England, M13 9NR, United Kingdom","address":{"university":"University of Manchester - Main Campus","city":"Manchester","county":"Greater Manchester","state_district":"North West England","state":"England","postcode":"M13 9NR","country":"UK","country_code":"gb"},"boundingbox":["53.4598667","53.4716848","-2.2390346","-2.2262754"]}
|
||||
JSON;
|
||||
$mock = new MockHandler([
|
||||
new Response(200, ['Content-Type' => 'application/json'], $json),
|
||||
]);
|
||||
$handler = HandlerStack::create($mock);
|
||||
$client = new Client(['handler' => $handler]);
|
||||
|
||||
$this->app->instance(Client::class, $client);
|
||||
|
||||
$note = new Note();
|
||||
$address = $note->reverseGeoCode(53.466277988406, -2.2304474827445);
|
||||
|
||||
$this->assertEquals('<span class="p-locality">Manchester</span>, <span class="p-country-name">UK</span>', $address);
|
||||
}
|
||||
|
||||
/** @test */
|
||||
public function reverse_geocode_a_county()
|
||||
{
|
||||
// Note I’ve removed everything below county to test for querires where
|
||||
// that’s all that is returned
|
||||
$json = <<<JSON
|
||||
{"place_id":"98085404","licence":"Data © OpenStreetMap contributors, ODbL 1.0. https:\/\/osm.org\/copyright","osm_type":"way","osm_id":"103703318","lat":"51.0997470194065","lon":"0.609897771085209","display_name":"Biddenden, Ashford, Kent, South East, England, TN27 8ET, United Kingdom","address":{"county":"Kent","state_district":"South East","state":"England","postcode":"TN27 8ET","country":"UK","country_code":"gb"},"boundingbox":["51.0986632","51.104459","0.5954434","0.6167775"]}
|
||||
JSON;
|
||||
$mock = new MockHandler([
|
||||
new Response(200, ['Content-Type' => 'application/json'], $json),
|
||||
]);
|
||||
$handler = HandlerStack::create($mock);
|
||||
$client = new Client(['handler' => $handler]);
|
||||
|
||||
$this->app->instance(Client::class, $client);
|
||||
|
||||
$note = new Note();
|
||||
$address = $note->reverseGeoCode(51.1, 0.61);
|
||||
|
||||
$this->assertEquals('<span class="p-region">Kent</span>, <span class="p-country-name">UK</span>', $address);
|
||||
}
|
||||
|
||||
/** @test */
|
||||
public function reverse_geocode_a_country()
|
||||
{
|
||||
// Note I’ve removed everything below country to test for querires where
|
||||
// that’s all that is returned
|
||||
$json = <<<JSON
|
||||
{"place_id":"120553244","licence":"Data © OpenStreetMap contributors, ODbL 1.0. https:\/\/osm.org\/copyright","osm_type":"way","osm_id":"191508282","lat":"54.3004150140189","lon":"-9.39993720828084","display_name":"R314, Doonfeeny Lower, Ballycastle ED, Ballina, County Mayo, Connacht, Ireland","address":{"country":"Ireland","country_code":"ie"},"boundingbox":["54.2964027","54.3045856","-9.4337961","-9.3960403"]}
|
||||
JSON;
|
||||
$mock = new MockHandler([
|
||||
new Response(200, ['Content-Type' => 'application/json'], $json),
|
||||
]);
|
||||
$handler = HandlerStack::create($mock);
|
||||
$client = new Client(['handler' => $handler]);
|
||||
|
||||
$this->app->instance(Client::class, $client);
|
||||
|
||||
$note = new Note();
|
||||
$address = $note->reverseGeoCode(54.3, 9.4);
|
||||
|
||||
$this->assertEquals('<span class="p-country-name">Ireland</span>', $address);
|
||||
}
|
||||
|
||||
/** @test */
|
||||
public function add_image_element_to_note_content()
|
||||
{
|
||||
$media = new Media([
|
||||
'type' => 'image',
|
||||
'path' => 'test.png']
|
||||
);
|
||||
$media->save();
|
||||
$note = new Note(['note' => 'A nice image']);
|
||||
$note->save();
|
||||
$note->media()->save($media);
|
||||
|
||||
$expected = "<p>A nice image</p>
|
||||
<img src=\"" . config('filesystems.disks.s3.url') . "/test.png\" alt=\"\">";
|
||||
$this->assertEquals($expected, $note->content);
|
||||
}
|
||||
|
||||
/** @test */
|
||||
public function add_video_element_to_note_content()
|
||||
{
|
||||
$media = new Media([
|
||||
'type' => 'video',
|
||||
'path' => 'test.mkv']
|
||||
);
|
||||
$media->save();
|
||||
$note = new Note(['note' => 'A nice video']);
|
||||
$note->save();
|
||||
$note->media()->save($media);
|
||||
|
||||
$expected = "<p>A nice video</p>
|
||||
<video src=\"" . config('filesystems.disks.s3.url') . "/test.mkv\">";
|
||||
$this->assertEquals($expected, $note->content);
|
||||
}
|
||||
|
||||
/** @test */
|
||||
public function add_audio_element_to_note_content()
|
||||
{
|
||||
$media = new Media([
|
||||
'type' => 'audio',
|
||||
'path' => 'test.flac']
|
||||
);
|
||||
$media->save();
|
||||
$note = new Note(['note' => 'Some nice audio']);
|
||||
$note->save();
|
||||
$note->media()->save($media);
|
||||
|
||||
$expected = "<p>Some nice audio</p>
|
||||
<audio src=\"" . config('filesystems.disks.s3.url') . "/test.flac\">";
|
||||
$this->assertEquals($expected, $note->content);
|
||||
}
|
||||
|
||||
/** @test */
|
||||
public function blank_note_content()
|
||||
{
|
||||
$note = new Note();
|
||||
|
||||
$this->assertEquals('A blank note', $note->content);
|
||||
}
|
||||
|
||||
/** @test */
|
||||
public function twitter_content_is_null_when_oembed_error_occurs()
|
||||
{
|
||||
Twitter::shouldReceive('getOembed')
|
||||
->once()
|
||||
->andThrow('Exception');
|
||||
|
||||
$note = new Note();
|
||||
$note->in_reply_to = 'https://twitter.com/foo';
|
||||
|
||||
$this->assertNull($note->twitter);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue