Commit graph jonnybarnes.uk/app/Http/Controllers/MicropubMediaController.php
Author SHA1 Message Date
faf8e5c1ec
Fix CSRF exemption and array-input crash on revocation/introspection
An Opus code review of the branch caught two real bugs the test suite
structurally couldn't see:

- /revocation and /introspect were never added to bootstrap/app.php's
  CSRF except list, so both were fully broken (403) for any real
  external client, despite every feature test passing — CSRF
  verification is short-circuited entirely while running tests.
  Verified live against the running app before and after the fix, and
  added a regression test that asserts against the actual configured
  exemptions rather than relying on request-time behavior that tests
  can't exercise.

- An array-shaped `token` param (e.g. token[]=a&token[]=b) crashed
  both endpoints with a 500, since this app promotes PHP warnings
  ("Array to string conversion") to exceptions. Fixed at the shared
  root, MicropubToken::findActive(), which also closes the same latent
  hole in VerifyMicropubToken's access_token param that predates this
  branch. Verified live and covered with regression tests.

Also applied the review's lower-severity findings: added the missing
introspection_endpoint Link header and metadata test assertions,
removed the now-dead is_string($scopes) array branch in the Micropub
handlers and media controller (scope is unconditionally a string from
the DB now, this guarded against a JWT-array-claim shape that can no
longer occur), dropped a redundant #[Table] model attribute, sized
token_hash to its actual 64-char length, and removed a one-off inline
style in the admin view.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014625MfkGZ7GVdbqKme4a8L
2026-08-13 17:03:43 +01:00
31c49ac3fc
Adopt Laravel's Image facade for media processing, upgrade Intervention to v4
Laravel 13's Image facade wraps Intervention Image v4 internally, so
switching our upload width probe and resize job/command to it required
bumping intervention/image ^3 -> ^4 (and its intervention/gif ^5
dependency). Removes our own ImageManager container binding and
config/image.php in favour of Laravel's built-in driver resolution.

Also fixes a latent filename mismatch in ProcessMediaJobTest that Pint's
stricter typing on the new Image API turned into a hard TypeError, and
tidies config/flare.php to use imported class names instead of FQCNs.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018Sorsgn85nw7uQyRMNvzyD
2026-08-01 17:07:38 +01:00
9f012b01e4
Upgrade to Laravel 13 2026-04-07 09:01:19 +01:00
23c275945a
Refactor micropub token verification 2025-04-12 11:47:30 +01:00
cd5c97afd3
Remove psalm annotations 2025-04-10 20:09:36 +01:00
1dfa17abca
Update Laravel to v12
Some checks failed
PHP Unit / PHPUnit test suite (pull_request) Has been cancelled
Laravel Pint / Laravel Pint (pull_request) Has been cancelled
2025-04-01 21:10:30 +01:00
d7da42b626
Host images locally
Some checks failed
PHP Unit / PHPUnit test suite (pull_request) Has been cancelled
Laravel Pint / Laravel Pint (pull_request) Has been cancelled
We don’t need the complexity of S3. Sepcifically the complexity of
managing my own AWS account, flysystem made the Laravel side easy.

A command is added to copy the the S3 files over to local storage.
2024-10-25 20:40:52 +01:00
bcf61bb6a0
Fis Laravel Pint issues 2024-07-13 14:58:11 +01:00
baee7ade4f
Improve scope checking
Whether the scopes are defined as a space separated string, or an array,
we should now be checking them without any errors.
2024-07-13 14:52:57 +01:00
1874bc6f94
Laravel Pint fix 2024-02-17 17:59:18 +00:00
5fa788b362
Update intervention/image package
Also fix a unit test, the image package had changed how it loads images
so my test for is a file upload an image was failing
2024-02-17 17:47:12 +00:00
6d5b298837
Update Intervention/Image class to v3 2023-12-17 13:56:10 +00:00
39a197ae7b
refactor: Refactor file headers and add Psalm suppressions
- Added Psalm suppression annotations to multiple controller classes
- Added PHPDoc comment blocks to seeders and factories
- Added comments to indicate unused classes and methods
- Removed unused annotations and imports
2023-07-28 11:48:07 +01:00
16b120bc73
Upgrade to Laravel 10 2023-02-18 09:34:57 +00:00
6d6e719f52
Update Laravel Pint, fix files in codebase 2023-02-16 16:57:06 +00:00
33acf33be9
Update Laravel Pint and fix code style 2022-12-02 19:49:29 +00:00
cfca6a1de5
Refactor models to use new attribute cast 2022-11-26 10:55:58 +00:00
42f0fa2238
Return a published and mime type data with sourced media uploads 2022-11-20 17:12:22 +00:00
6c28f75678
Add Laravel Pint fixes 2022-11-16 21:07:59 +00:00
027eccfad8
Update querying of last uploaded media 2022-11-16 20:30:08 +00:00
e36f15d391
Fix files with Laravel Pint 2022-07-09 10:08:26 +01:00
d43530cdd2 Final prep work to get ready for PHP8 2020-12-31 13:34:55 +00:00
f73a5587dc No longer need our own token exception 2020-11-28 19:02:37 +00:00
6942fc1d32 Initial php8 work
- switch to GD for image work
 - fix issues around jwt
2020-11-28 18:21:29 +00:00
f01595f181 Fix phpcs error 2020-08-15 10:06:26 +01:00
ae2c45ff3d Add media endpoint support for the source parameter 2020-08-15 09:56:33 +01:00
95bf302dcd Replicate what aaronpk does in his endpoint 2020-06-28 17:21:21 +01:00
b764066d98 Only return media added in last half hour 2020-06-28 16:30:56 +01:00
4f2d3b7c2b Media Endpoint improvements
For the code, media related stuff is now in its own controller

Added support for querying the most recent file uploaded
2020-06-27 14:13:33 +01:00