Replaces every raw GuzzleHttp\Client usage (Nominatim, web.archive.org, webmention fetch/discover/send, Bridgy syndication, IndieAuth client_id lookup, contact avatar/h-card fetch, profile image download, and the CloudConvert screenshot pipeline) with Illuminate\Support\Facades\Http, and enables Http::preventStrayRequests() globally in tests so any un-faked outbound call now fails loudly instead of silently hitting the network. The CloudConvert retry-until-finished middleware in AppServiceProvider is replaced by a plain polling loop in SaveScreenshot, which also fixes a latent bug where the old middleware decoded a response object instead of its body. Bridgy syndication jobs keep their tries=1/no-retry semantics unchanged to avoid duplicate publishes. Guzzle's PSR-7 helpers (Header, UriResolver, Utils) stay in SendWebMentions since Http has no equivalent for them. Every affected test file's Guzzle MockHandler/HandlerStack boilerplate is replaced with Http::fake()/Http::sequence(). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P8j7cJhCiYDsGUgB7obKNQ
154 lines
4.8 KiB
PHP
154 lines
4.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Tests\Unit\Jobs;
|
|
|
|
use App\Jobs\SaveProfileImage;
|
|
use Illuminate\Support\Facades\Http;
|
|
use Jonnybarnes\WebmentionsParser\Authorship;
|
|
use Jonnybarnes\WebmentionsParser\Exceptions\AuthorshipParserException;
|
|
use PHPUnit\Framework\Attributes\Test;
|
|
use Tests\TestCase;
|
|
|
|
class SaveProfileImageJobTest extends TestCase
|
|
{
|
|
protected function tearDown(): void
|
|
{
|
|
if (file_exists(public_path().'/assets/profile-images/example.org/image')) {
|
|
unlink(public_path().'/assets/profile-images/example.org/image');
|
|
rmdir(public_path().'/assets/profile-images/example.org');
|
|
}
|
|
parent::tearDown();
|
|
}
|
|
|
|
#[Test]
|
|
public function authorship_algorithm_returns_null_on_exception(): void
|
|
{
|
|
$mf = ['items' => []];
|
|
$authorship = $this->createMock(Authorship::class);
|
|
$authorship->method('findAuthor')
|
|
->will($this->throwException(new AuthorshipParserException));
|
|
$job = new SaveProfileImage($mf);
|
|
|
|
$this->assertNull($job->handle($authorship));
|
|
}
|
|
|
|
#[Test]
|
|
public function we_do_not_process_twitter_images(): void
|
|
{
|
|
$mf = ['items' => []];
|
|
$author = [
|
|
'properties' => [
|
|
'photo' => ['https://pbs.twimg.com/abc.jpg'],
|
|
'url' => ['https://twitter.com/profile'],
|
|
],
|
|
];
|
|
$authorship = $this->createMock(Authorship::class);
|
|
$authorship->method('findAuthor')
|
|
->willReturn($author);
|
|
$job = new SaveProfileImage($mf);
|
|
|
|
$this->assertNull($job->handle($authorship));
|
|
}
|
|
|
|
#[Test]
|
|
public function remote_author_images_are_saved_locally(): void
|
|
{
|
|
Http::fake([
|
|
'*' => Http::response('fake jpeg image', 200, ['Content-Type' => 'image/jpeg']),
|
|
]);
|
|
$mf = ['items' => []];
|
|
$author = [
|
|
'properties' => [
|
|
'photo' => ['https://example.org/profile.jpg'],
|
|
'url' => ['https://example.org'],
|
|
],
|
|
];
|
|
$authorship = $this->createMock(Authorship::class);
|
|
$authorship->method('findAuthor')
|
|
->willReturn($author);
|
|
|
|
$job = new SaveProfileImage($mf);
|
|
$job->handle($authorship);
|
|
$this->assertFileExists(public_path().'/assets/profile-images/example.org/image');
|
|
}
|
|
|
|
#[Test]
|
|
public function local_default_author_image_is_used_as_fallback(): void
|
|
{
|
|
Http::fake([
|
|
'*' => Http::response('', 404),
|
|
]);
|
|
$mf = ['items' => []];
|
|
$author = [
|
|
'properties' => [
|
|
'photo' => ['https://example.org/profile.jpg'],
|
|
'url' => ['https://example.org'],
|
|
],
|
|
];
|
|
$authorship = $this->createMock(Authorship::class);
|
|
$authorship->method('findAuthor')
|
|
->willReturn($author);
|
|
|
|
$job = new SaveProfileImage($mf);
|
|
$job->handle($authorship);
|
|
$this->assertFileEquals(
|
|
public_path().'/assets/profile-images/default-image',
|
|
public_path().'/assets/profile-images/example.org/image'
|
|
);
|
|
}
|
|
|
|
#[Test]
|
|
public function we_get_url_from_photo_object_if_alt_text_is_provided(): void
|
|
{
|
|
Http::fake([
|
|
'*' => Http::response('fake jpeg image', 200, ['Content-Type' => 'image/jpeg']),
|
|
]);
|
|
$mf = ['items' => []];
|
|
$author = [
|
|
'properties' => [
|
|
'photo' => [[
|
|
'value' => 'https://example.org/profile.jpg',
|
|
'alt' => null,
|
|
]],
|
|
'url' => ['https://example.org'],
|
|
],
|
|
];
|
|
$authorship = $this->createMock(Authorship::class);
|
|
$authorship->method('findAuthor')
|
|
->willReturn($author);
|
|
|
|
$job = new SaveProfileImage($mf);
|
|
$job->handle($authorship);
|
|
$this->assertFileExists(public_path().'/assets/profile-images/example.org/image');
|
|
}
|
|
|
|
#[Test]
|
|
public function use_first_url_if_multiple_homepages_are_provided(): void
|
|
{
|
|
Http::fake([
|
|
'*' => Http::response('fake jpeg image', 200, ['Content-Type' => 'image/jpeg']),
|
|
]);
|
|
$mf = ['items' => []];
|
|
$author = [
|
|
'properties' => [
|
|
'photo' => [[
|
|
'value' => 'https://example.org/profile.jpg',
|
|
'alt' => null,
|
|
]],
|
|
'url' => [[
|
|
'https://example.org',
|
|
'https://example.com',
|
|
]],
|
|
],
|
|
];
|
|
$authorship = $this->createMock(Authorship::class);
|
|
$authorship->method('findAuthor')
|
|
->willReturn($author);
|
|
|
|
$job = new SaveProfileImage($mf);
|
|
$job->handle($authorship);
|
|
$this->assertFileExists(public_path().'/assets/profile-images/example.org/image');
|
|
}
|
|
}
|