jonny/jonnybarnes.uk
1
0
Fork 0
Code Issues 5 Pull requests Projects Releases 5 Packages Wiki Activity Actions

Fix showing author names in WebMentions #18

Merged
jonny merged 2 commits from fix_author_name_missing_in_webmentions into develop 2024-11-30 16:34:25 +01:00
Conversation 1 Commits 2 Files changed 3 +12 -4
jonny commented 2024-11-30 16:33:06 +01:00
Owner
Copy link

This covers likes, reposts and replies.

If we can’t determine the author name, for now we shall just display unknown so at least the page doesn’t error. This could be improved in the future.

This covers likes, reposts and replies. If we can’t determine the author name, for now we shall just display `unknown` so at least the page doesn’t error. This could be improved in the future.
jonny added 2 commits 2024-11-30 16:33:07 +01:00
Apply the same fix to replies and reposts
Some checks failed
PHP Unit / PHPUnit test suite (pull_request) Has been cancelled
Details
Laravel Pint / Laravel Pint (pull_request) Has been cancelled
Details
84383ecd31
jonny commented 2024-11-30 16:33:24 +01:00
Author
Owner
Copy link

This should fix #17 for now.

This should fix #17 for now.
jonny merged commit 84383ecd31 into develop 2024-11-30 16:34:25 +01:00
jonny deleted branch fix_author_name_missing_in_webmentions 2024-11-30 16:34:25 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jonny/jonnybarnes.uk#18
No description provided.
Delete branch "fix_author_name_missing_in_webmentions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?